[PATCH] D99509: [RISCV] Add legality check for vectoring reduction

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 10:16:35 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.h:151
+    case RecurKind::UMax:
+    case RecurKind::FMin:
+    case RecurKind::FMax:
----------------
luke957 wrote:
> frasercrmck wrote:
> > We don't support the fmin/fmax reductions yet. I suspect this would crash in the backend?
> The added test case contains a fmin case. For opt -loop-vectorize, it seems no crash.
The crash would be in llc in SelectionDAG, not opt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99509/new/

https://reviews.llvm.org/D99509



More information about the llvm-commits mailing list