[PATCH] D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:462
+    if (CurrentDirectiveIsNested() &&
+        llvm::omp::nestedBarrierErrSet.test(GetContextParent().directive)) {
+      context_.Say(parser::FindSourceLocation(x),
----------------
Definition of closely nested region is 
"A region nested inside another region with no parallel region nested between them."

Does this check capture this definition correctly?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:469-482
+  // const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)};
+  // const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)};
+  // if (beginDir.v == llvm::omp::Directive::OMPD_do) {
+  //   if (const auto &doConstruct{
+  //           std::get<std::optional<parser::DoConstruct>>(x.t)}) {
+  //     if (doConstruct.value().IsDoWhile()) {
+  //       const auto
----------------
Nit: Remove commented code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99888/new/

https://reviews.llvm.org/D99888