[PATCH] D99698: [DWARF] Fix crash for DWARFDie::dump.

Mon Apr 5 09:53:24 PDT 2021

ayermolo added a comment.

In D99698#2665550 <https://reviews.llvm.org/D99698#2665550>, @dblaikie wrote:

> Test case?

I am not sure how to test it. I think only way to trigger it is to manually extract DIE with children like done here: https://github.com/facebookincubator/BOLT/blob/68abc968b706b55585b1b8be315aef5d3bf90b1c/bolt/src/DWARFRewriter.cpp#L129
Then invoke dump() on it.

I guess one way would be to add this method of an extraction to an API, and modify one of the tools to use it.
Another write a small program that does it and have it as part of the test suite.

My understanding it's done that way vs using current APIs is to keep memory footprint down.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99698/new/

https://reviews.llvm.org/D99698