[PATCH] D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 09:03:51 PDT 2021


epastor accepted this revision.
epastor added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:435
+  // as they probably would be needed for asm goto
+  if (LexHLASMIntegers || CurPtr[-1] != '0' || CurPtr[0] == '.') {
     unsigned Radix = doHexLookAhead(CurPtr, 10, LexMasmIntegers);
----------------
epastor wrote:
> Should this be `(LexHLASMIntegers || CurPtr[-1] != 0) || CurPtr[0] == '.'`? The parentheses may be relevant here, since you probably still want floating point literals starting or ending with '.' to be handled.
I withdraw this comment... I think I thought the latter `||` was an `&&`. Apologies!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99374/new/

https://reviews.llvm.org/D99374



More information about the llvm-commits mailing list