[PATCH] D99886: [CMake] Propagate static extensions to LLVMExtensions object library

Raul Tambre via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 08:58:15 PDT 2021


tambre created this revision.
tambre added reviewers: tstellar, stellaraccident.
Herald added a subscriber: mgorny.
Herald added a reviewer: bollu.
tambre requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Since 43ceb74eb1a5801662419fb66a6bf0d5414f1ec5 <https://reviews.llvm.org/rG43ceb74eb1a5801662419fb66a6bf0d5414f1ec5> llvm-shlib links against the object libraries instead of static libraries.
This causes build failures if building Polly statically into LLVM as the dependency on it isn't propagated through LLVMExtension's object library variant.

Simply attach the transitive dependency to the object variant to fix this.
Fixes PR 49843.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99886

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1006,6 +1006,7 @@
   foreach(llvm_extension ${LLVM_STATIC_EXTENSIONS})
       set_property(TARGET LLVMExtensions APPEND PROPERTY LINK_LIBRARIES ${llvm_extension})
       set_property(TARGET LLVMExtensions APPEND PROPERTY INTERFACE_LINK_LIBRARIES ${llvm_extension})
+      set_property(TARGET obj.LLVMExtensions APPEND PROPERTY INTERFACE_LINK_LIBRARIES ${llvm_extension})
   endforeach()
 
   # Eventually generate the extension headers, and store config to a cmake file


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99886.335269.patch
Type: text/x-patch
Size: 656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210405/c07dfdde/attachment.bin>


More information about the llvm-commits mailing list