[PATCH] D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers
Anirudh Prasad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 5 08:43:56 PDT 2021
anirudhp marked an inline comment as done.
anirudhp added inline comments.
================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:327-328
+ if (LexHLASMIntegers) {
+ // You can have leading 0s in HLASM-flavour integers
+ // They don't mean octal integers
+ unsigned Radix = doHexLookAhead(CurPtr, 10, /*LexMasmIntegers=*/false);
----------------
epastor wrote:
> Can we save a lot of code here by removing this whole segment and making the decimal parsing below work even with leading 0 when LexHLASMIntegers is set?
>
> Right now, this seems very redundant.
Done! Thanks for the hint!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99374/new/
https://reviews.llvm.org/D99374
More information about the llvm-commits
mailing list