[PATCH] D99087: [RISCV] Fix stack slot for argument types (Bug 49500)
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 5 05:15:33 PDT 2021
frasercrmck added a comment.
In D99087#2668854 <https://reviews.llvm.org/D99087#2668854>, @luismarques wrote:
> My concern with leaving it up to a follow-up patch is that 1) for "normal" types, we're already using `getPrefTypeAlign` (under the covers), so in a sense this patch would be a slight regression; 2) it's easy to never follow up on these kinds of things.
> Do you reckon it would be hard to verify each? (I imagine that the stack allocation is either the same or increases for all of those impacted tests, right?)
Yes, fair enough. I've updated the diff to use the preferred type alignment. We can always revert for whatever reason. I'll try and take a look through the diffs later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99087/new/
https://reviews.llvm.org/D99087
More information about the llvm-commits
mailing list