[PATCH] D99087: [RISCV] Fix stack slot for argument types (Bug 49500)

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D99087#2668842 <https://reviews.llvm.org/D99087#2668842>, @frasercrmck wrote:

> In D99087#2668840 <https://reviews.llvm.org/D99087#2668840>, @frasercrmck wrote:
>
>> Hmm good catch. Shame there's no DAG wrapper for that method; targets don't typically use it. I could look into it before merging, if you like?
>
> Using the preferred type align does produce changes in 7 of our tests. Maybe we should leave it to a follow-up patch? We'd be best verifying that each is correct.

My concern with leaving it up to a follow-up patch is that 1) for "normal" types, we're already using `getPrefTypeAlign` (under the covers), so in a sense this patch would be a slight regression; 2) it's easy to never follow up on these kinds of things.
Do you reckon it would be hard to verify each? (I imagine that the stack allocation is either the same or increases for all of those impacted tests, right?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99087/new/

https://reviews.llvm.org/D99087