[PATCH] D99087: [RISCV] Fix stack slot for argument types (Bug 49500)

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 04:09:39 PDT 2021


frasercrmck added a comment.

In D99087#2668140 <https://reviews.llvm.org/D99087#2668140>, @luismarques wrote:

> BTW, it shouldn't affect correctness but the original `CreateStackTemporary` would use (as part of that method's implementation) `getPrefTypeAlign` instead of `getEVTAlign`. In principle that would allow better alignment choices, although at the moment it probably would never make any difference.

Hmm good catch. Shame there's no DAG wrapper for that method; targets don't typically use it. I could look into it before merging, if you like?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99087/new/

https://reviews.llvm.org/D99087



More information about the llvm-commits mailing list