[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

[Serguei Katkov via Phabricator via llvm-commits]

skatkov accepted this revision.
skatkov added a comment.
This revision is now accepted and ready to land.

with two nits.



================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422
+  // Register all the standard instrumentation callbacks. If \p FAM is nullptr
+  // then PreservedCFGChecker is not registeredenabled.
+  void registerCallbacks(PassInstrumentationCallbacks &PIC,
----------------
yrouban wrote:
> fix registeredenabled
Not Done.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1079
+        const auto *F = any_cast<const Function *>(IR);
+        FAM.getResult<PreservedCFGCheckerAnalysis>(*const_cast<Function *>(F));
+      });
----------------
Add a comment that you caches the CFG before pass.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91327/new/

https://reviews.llvm.org/D91327