[PATCH] D99654: [RISCV] Expand scalable-vector truncstores and extloads

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked 3 inline comments as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:489
+
+      for (MVT OtherVT : IntVecVTs) {
+        setLoadExtAction(ISD::EXTLOAD, OtherVT, VT, Expand);
----------------
craig.topper wrote:
> You might be better off using integer_scalable_vector_valuetypes(). We need to block mask vectors too.
Good catch, thanks.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:556
         for (MVT OtherVT : MVT::fixedlen_vector_valuetypes())
           setTruncStoreAction(VT, OtherVT, Expand);
 
----------------
craig.topper wrote:
> LoadExt for integer fixed vectors is missing.
Done.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:559
         SetCommonVFPActions(VT);
+      SetCommonVFPExtLoadTruncStoreActions(VT, makeArrayRef(F16VecVTs));
+    }
----------------
craig.topper wrote:
> Is the explicit makeArrayRef needed?
Turns out it's not, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99654/new/

https://reviews.llvm.org/D99654