[PATCH] D99874: [lld-macho][nfc] Remove HelpHidden from aliases to implemented flags

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 4 23:52:23 PDT 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a subscriber: dang.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a no-op. Just cleaning up Options.td...


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99874

Files:
  lld/MachO/Options.td
  lld/test/MachO/sectcreate.s
  lld/test/MachO/why-load.s


Index: lld/test/MachO/why-load.s
===================================================================
--- lld/test/MachO/why-load.s
+++ lld/test/MachO/why-load.s
@@ -12,7 +12,7 @@
 # The first line checks that we never demangle symbols in -why_load output.
 # RUN: %lld %t/main.o %t/lib.a -o /dev/null -why_load -demangle | \
 # RUN:     FileCheck %s --check-prefix=WHY
-# RUN: %lld %t/main.o -force_load %t/lib.a -o /dev/null -why_load | \
+# RUN: %lld %t/main.o -force_load %t/lib.a -o /dev/null -whyload | \
 # RUN:     FileCheck %s --check-prefix=WHYFORCE
 # RUN: %lld %t/main.o %t/lib.a -o /dev/null -all_load -why_load | \
 # RUN:     FileCheck %s --check-prefix=WHYALL
Index: lld/test/MachO/sectcreate.s
===================================================================
--- lld/test/MachO/sectcreate.s
+++ lld/test/MachO/sectcreate.s
@@ -5,7 +5,7 @@
 # RUN: echo "-sectcreate 2" >%t3
 # RUN: %lld \
 # RUN:     -sectcreate SEG SEC1 %t1 \
-# RUN:     -sectcreate SEG SEC2 %t3 \
+# RUN:     -segcreate SEG SEC2 %t3 \
 # RUN:     -sectcreate SEG SEC1 %t2 \
 # RUN:     -o %t %t.o
 # RUN: llvm-objdump -s %t | FileCheck %s
Index: lld/MachO/Options.td
===================================================================
--- lld/MachO/Options.td
+++ lld/MachO/Options.td
@@ -189,7 +189,6 @@
     MetaVarName<"<segment> <section> <file>">,
     Alias<sectcreate>,
     HelpText<"Alias for -sectcreate">,
-    Flags<[HelpHidden]>,
     Group<grp_content>;
 def filelist : Separate<["-"], "filelist">,
     MetaVarName<"<file>">,
@@ -335,13 +334,11 @@
     MetaVarName<"<name>">,
     Alias<install_name>,
     HelpText<"Alias for -install_name">,
-    Flags<[HelpHidden]>,
     Group<grp_dylib>;
 def dylinker_install_name : Separate<["-"], "dylinker_install_name">,
     MetaVarName<"<name>">,
     Alias<install_name>,
     HelpText<"Alias for -install_name">,
-    Flags<[HelpHidden]>,
     Group<grp_dylib>;
 def mark_dead_strippable_dylib : Flag<["-"], "mark_dead_strippable_dylib">,
     HelpText<"Mark output dylib as dead-strippable: When a client links against it but does not use any of its symbols, the dylib will not be added to the client's list of needed dylibs">,
@@ -481,7 +478,6 @@
 def whyload : Flag<["-"], "whyload">,
     Alias<why_load>,
     HelpText<"Alias for -why_load">,
-    Flags<[HelpHidden]>,
     Group<grp_introspect>;
 def why_live : Separate<["-"], "why_live">,
     MetaVarName<"<symbol>">,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99874.335209.patch
Type: text/x-patch
Size: 2427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210405/8d02da84/attachment.bin>


More information about the llvm-commits mailing list