[PATCH] D99842: [lld-macho][nfc] POC for 32 bit support

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 4 23:51:25 PDT 2021


int3 added a comment.

Yeah I'm not a fan of this. I think passing the offset is fine: we call it in exactly one place in the code, so there's little risk of confusion. And LLD-ELF has a similar design.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99842/new/

https://reviews.llvm.org/D99842



More information about the llvm-commits mailing list