[PATCH] D99869: [M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro

[John Paul Adrian Glaubitz via Phabricator via llvm-commits]

glaubitz created this revision.
glaubitz added reviewers: myhsu, jrtc27, MaskRay.
Herald added a subscriber: hiraditya.
glaubitz requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In 0dbcb3639451 <https://reviews.llvm.org/rG0dbcb3639451a7c20e2d5133b459552281e64455>, most most target symbols were made hidden by default
with the public ones marked with LLVM_EXTERNAL_VISIBILITY. When the
M68k target was added, this particular change was forgotten so that
external tools cannot make use of the public M68k target functions
in libLLVM.so. Thus, add the missing LLVM_EXTERNAL_VISIBILITY macro
to all public target functions in the M68k backend.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99869

Files:
  llvm/lib/Target/M68k/M68kAsmPrinter.cpp
  llvm/lib/Target/M68k/M68kTargetMachine.cpp
  llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
  llvm/lib/Target/M68k/TargetInfo/M68kTargetInfo.cpp


Index: llvm/lib/Target/M68k/TargetInfo/M68kTargetInfo.cpp
===================================================================
--- llvm/lib/Target/M68k/TargetInfo/M68kTargetInfo.cpp
+++ llvm/lib/Target/M68k/TargetInfo/M68kTargetInfo.cpp
@@ -21,7 +21,7 @@
 }
 } // namespace llvm
 
-extern "C" void LLVMInitializeM68kTargetInfo() {
+extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeM68kTargetInfo() {
   RegisterTarget<Triple::m68k, /*HasJIT=*/true> X(
       getTheM68kTarget(), "m68k", "Motorola 68000 family", "M68k");
 }
Index: llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
===================================================================
--- llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
+++ llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
@@ -106,7 +106,7 @@
   return new M68kInstPrinter(MAI, MII, MRI);
 }
 
-extern "C" void LLVMInitializeM68kTargetMC() {
+extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeM68kTargetMC() {
   Target &T = getTheM68kTarget();
 
   // Register the MC asm info.
Index: llvm/lib/Target/M68k/M68kTargetMachine.cpp
===================================================================
--- llvm/lib/Target/M68k/M68kTargetMachine.cpp
+++ llvm/lib/Target/M68k/M68kTargetMachine.cpp
@@ -28,7 +28,7 @@
 
 #define DEBUG_TYPE "m68k"
 
-extern "C" void LLVMInitializeM68kTarget() {
+extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeM68kTarget() {
   RegisterTargetMachine<M68kTargetMachine> X(getTheM68kTarget());
 }
 
Index: llvm/lib/Target/M68k/M68kAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/M68k/M68kAsmPrinter.cpp
+++ llvm/lib/Target/M68k/M68kAsmPrinter.cpp
@@ -65,6 +65,6 @@
 
 void M68kAsmPrinter::emitEndOfAsmFile(Module &M) {}
 
-extern "C" void LLVMInitializeM68kAsmPrinter() {
+extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeM68kAsmPrinter() {
   RegisterAsmPrinter<M68kAsmPrinter> X(getTheM68kTarget());
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99869.335185.patch
Type: text/x-patch
Size: 1955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210404/d2023ba2/attachment.bin>