[PATCH] D99621: [CMake][Compiler-rt] Make it possible to configure standalone compiler-rt without `LLVMConfig.cmake`.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 4 11:52:01 PDT 2021
mstorsjo added a comment.
In D99621#2667774 <https://reviews.llvm.org/D99621#2667774>, @delcypher wrote:
> So that would suggest that both `CMAKE_C_COMPILER_TARGET` and `COMPILER_RT_DEFAULT_TARGET_ONLY` get set.
>
> **If I've read this correctly** that means this patch doesn't need to change because it already checks for `CMAKE_C_COMPILER_TARGET` and `COMPILER_RT_DEFAULT_TARGET_ONLY` being set and defers to using `CMAKE_C_COMPILER_TARGET` to set `TARGET_TRIPLE` in that case.
Thanks for digging into that! That sounds plausible, and that narrows down the interfaces towards how compiler-rt actually gets configured a little bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99621/new/
https://reviews.llvm.org/D99621
More information about the llvm-commits
mailing list