[PATCH] D99856: [Coroutines, test] Fix use of var defined in CHECK-NOT

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 4 00:26:38 PDT 2021


thopre created this revision.
thopre added reviewers: junparser, lxfind, modocache, lewissbaker.
Herald added a subscriber: ChuanqiXu.
thopre requested review of this revision.
Herald added a project: LLVM.

LLVM test Transforms/Coroutine/coro-split-sink-lifetime-O2.ll tries to
check for the absence of a sequence of instructions with several
CHECK-NOT with one of those directives using a variable defined in
another. However CHECK-NOT are checked independently so that is using a
variable defined in a pattern that should not occur in the input.

This commit simplifies the CHECK-NOT block to only check for the
presence of any lifetime start marker since that is effectively what
the test was testing at the moment.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99856

Files:
  llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll


Index: llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
===================================================================
--- llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
+++ llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
@@ -57,9 +57,7 @@
 
 ; CHECK-LABEL: @a.resume(
 ; CHECK:    %[[VAL:testval.+]] = getelementptr inbounds %a.Frame
-; CHECK-NOT:     %testval = alloca i32, align 4
-; CHECK-NOT:     %[[CAST:.+]] = bitcast i32* %testval to i8*
-; CHECK-NOT:     call void @llvm.lifetime.start.p0i8(i64 4, i8* %[[CAST]])
+; CHECK-NOT:     call void @llvm.lifetime.start.p0i8(i64 4, i8* %{{.*}})
 ; CHECK:         %test = load i32, i32* %[[VAL]]
 ; CHECK-NOT:     %test = load i32, i32* %testval
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99856.335135.patch
Type: text/x-patch
Size: 748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210404/f4a4c596/attachment.bin>


More information about the llvm-commits mailing list