[PATCH] D99822: [lld-macho] Add support for arm64_32

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 3 14:14:29 PDT 2021


int3 added a comment.

> Can ARM64 inherit from ARMCommon and TargetInfo? Multiple inheritance is a bit hacky.

You mean multiple *levels* of inheritance is hacky, right? Multiple inheritance seems to be what you are describing -- having ARM64 inherit from two direct parent classes. But I think having ARM64Common inherit directly from TargetInfo makes sense since it's implementing some of TargetInfo's virtual methods...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99822/new/

https://reviews.llvm.org/D99822



More information about the llvm-commits mailing list