[PATCH] D99843: [LoopRotate] Don't split pass manager

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: asbirlea, wenlei, lebedev.ri.
Herald added a subscriber: hiraditya.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

After D99249 <https://reviews.llvm.org/D99249> we use three different loop pass managers for LICM, LoopRotate and LICM+LoopUnswitch. This happens because LazyBFI and LazyBPI are not preserved by LoopRotate (note that D74640 <https://reviews.llvm.org/D74640> is no longer needed). Avoid this by marking them as preserved.

My understanding of D86156 <https://reviews.llvm.org/D86156> is that it is okay to simply preserve them (which LoopUnswitch already does for the same reason) and rely on callbacks to deal with deleted blocks.

Compile-time (only affects LegacyPM): https://llvm-compile-time-tracker.com/compare.php?from=665065821e6ae11deb9796a27b97a399e4bb3b0d&to=3163a33f4d6fec546df2723b9c55da41342716a5&stat=instructions


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99843

Files:
  llvm/lib/Transforms/Scalar/LoopRotation.cpp
  llvm/test/Other/opt-O2-pipeline.ll
  llvm/test/Other/opt-O3-pipeline-enable-matrix.ll
  llvm/test/Other/opt-O3-pipeline.ll
  llvm/test/Other/opt-Os-pipeline.ll
  llvm/test/Other/pass-pipelines.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99843.335097.patch
Type: text/x-patch
Size: 4409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210403/2cc1cea5/attachment.bin>