[PATCH] D98540: WIP: [M68k] Implement Disassembler
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 3 04:19:55 PDT 2021
RKSimon added a comment.
Minor fly-by coding style comment
================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:62
+ void dump() const {
+ for (unsigned I = 0; I < Buffer.size(); ++I) {
+ for (unsigned B = 0; B < 16; ++B) {
----------------
(style) Don't re-evaluate a fixed array length.
```
for (unsigned I = 0, E = Buffer.size(); I != E; ++I) {`
```
Alternatively, AFAICT you might be able to use a for-range loop:
```
for (const auto &BufferValue : Buffer)
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98540/new/
https://reviews.llvm.org/D98540
More information about the llvm-commits
mailing list