[PATCH] D99305: [docs] Document our norms around reverts

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 14:33:07 PDT 2021


On Fri, Apr 2, 2021 at 3:55 PM Philip Reames via Phabricator <
reviews at reviews.llvm.org> wrote:

> reames added inline comments.
>
>
> ================
> Comment at: llvm/docs/DeveloperPolicy.rst:330
> +* In general, if the author themselves would revert the change per these
> +  guidelines, we encourage other contributors to do so as a favor to the
> +  author.  This is one of the major cases where our norms differ from
> others;
> ----------------
> echristo wrote:
> > reames wrote:
> > > echristo wrote:
> > > > I think wording wise we can just remove the "... as a favor to the
> author." here and reword a little below...
> > > I left this one as is.  I took all your other edits, but taking this
> out seems to loose an important point to me.
> > I followed up offline here with an article that would help illustrate my
> point, but for me not having the "I'm doing you a favor" is important. It's
> not a favor, it's just how we work. There's no obligation or reciprocity
> expected which the text gives the impression of.
> You did, my apologies for not acknowledging that.
>
> I read the article you sent, it was definitely interesting, but it didn't
> change my take on this.
>
> I'm going to defer to Chris on this.  If he wants a change, I'll make it.
> If he's okay with the current wording, I'll leave it as is.
>

Referencing the article in general then:
https://greatergood.berkeley.edu/article/item/how_cultural_differences_shape_your_gratitude
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210402/fdd0983c/attachment.html>


More information about the llvm-commits mailing list