[PATCH] D99815: [CSSPGO][Test] XFAIL profile-context-tracker-debug.ll on AIX

[Jinsong Ji via Phabricator via llvm-commits]

jsji created this revision.
jsji added reviewers: PowerPC, hoy, wmi, wenlei, davidxl, hubert.reinterpretcast.
jsji requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The case start to fail since https://reviews.llvm.org/D99351.

Looks like to me that the node order within Context Profile Tree depends
on the implmementation of std::hash<std::string>.

Unfortunately, the current clang implementation generate different values on
AIX (or for all big-endian systems?)

On Linux:

  main: 2408804140(0x8f936f2c)

external:  896680882(0x357243b2)
externalA:  620231129(0x24f7f9d9)

On AIX:

  main:  994322777(0x3b442959)

external: 3548191215(0xd37d19ef)
externalA: 1390365101(0x52df49ad)

XFAIL it first while we discuss and seek for a fix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99815

Files:
  llvm/test/Transforms/SampleProfile/profile-context-tracker-debug.ll


Index: llvm/test/Transforms/SampleProfile/profile-context-tracker-debug.ll
===================================================================
--- llvm/test/Transforms/SampleProfile/profile-context-tracker-debug.ll
+++ llvm/test/Transforms/SampleProfile/profile-context-tracker-debug.ll
@@ -2,6 +2,11 @@
 ; Test for CSSPGO's SampleContextTracker to make sure context profile tree is promoted and merged properly
 ; based on inline decision, so post inline counts are accurate.
 
+;; The order of nodes within Context Profile Tree depends on the implmementation of std::hash<std::string>.
+;; Mark it fail on AIX for now before we figure out a solution.
+; XFAIL: aix
+
+
 ; Note that we need new pass manager to enable top-down processing for sample profile loader
 ; RUN: opt < %s -passes=sample-profile -sample-profile-file=%S/Inputs/profile-context-tracker.prof -sample-profile-inline-size -sample-profile-cold-inline-threshold=200 -debug-only=sample-context-tracker -o /dev/null 2>&1 | FileCheck %s --check-prefix=INLINE-ALL
 ; RUN: opt < %s -passes=sample-profile -sample-profile-file=%S/Inputs/profile-context-tracker.prof -sample-profile-prioritized-inline=0 -sample-profile-inline-size=0 -debug-only=sample-context-tracker -o /dev/null 2>&1 | FileCheck %s --check-prefix=INLINE-HOT


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99815.335026.patch
Type: text/x-patch
Size: 1290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210402/568f1b93/attachment-0001.bin>