[PATCH] D99560: Utility to construct visitors from lambdas.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 13:09:19 PDT 2021


lhames added a comment.

In D99560#2660464 <https://reviews.llvm.org/D99560#2660464>, @dblaikie wrote:

> Not asking you to do anything necessarily - though I think it's worth someone (you or @lhames perhaps) checking if the abstraction generalizes well to other/existing use cases.

This is dispatching based on static type, handleAllErrors is dispatching based on the dynamic type of the error. I suspect that those two use-cases are different enough that there's limited value in unifying the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99560/new/

https://reviews.llvm.org/D99560



More information about the llvm-commits mailing list