[PATCH] D99179: [RFC] [Coroutines] Enable printing coroutine frame in debugger if program is compiled with -g

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll:3-15
+; Checks whether the dbg.declare for `__coro_frame` are created.
+
+; CHECK-LABEL: define void @f(
+; CHECK:       coro.init:
+; CHECK:        %[[begin:.*]] = call noalias nonnull i8* @llvm.coro.begin(
+; CHECK:        %[[FramePtr:.*]] = bitcast i8* %[[begin]] to
+; CHECK:        call void @llvm.dbg.declare(metadata %f.Frame* %[[FramePtr]], metadata ![[CORO_FRAME:[0-9]+]], metadata !DIExpression())
----------------
This testing looks a bit more scant than I'd expect - to take a random example, the production code change in this patch includes what appears to be creating a type called `__resume_fn` - but the existence, spelling, and use of that type doesn't seem to be tested here. (same goes for lots of other stuff in the patch - looks like it's creating a whole bunch of debug metadata that doesn't seem to be tested here)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99179/new/

https://reviews.llvm.org/D99179