[PATCH] D98306: [ELF] Support . and $ in symbol names in expressions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:1419
+  if (!isValidSymbolName(tok))
     setError("malformed number: " + tok);
   script->referencedSymbols.push_back(tok);
----------------
jhenderson wrote:
> Idle thought I had whislt taking a quick look at this change: this error message doesn't seem particularly suitable to me. There's no guarantee that the user was trying to write a number. It could easily be they wanted a symbol name.
I noticed the same while touching this line but thought this should be a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98306/new/

https://reviews.llvm.org/D98306