[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190
+def err_riscv_builtin_requires_extension : Error<
+  "builtin requires %0 extension support to be enabled">;
 } // end of sema component.
----------------
jrtc27 wrote:
> This lost the quotes
I will fix when I rebase Zbb on top of this


================
Comment at: clang/lib/Sema/SemaChecking.cpp:3427
+      continue;
+    // Make message like "experimental-zbr" to "Zbr"
+    I.consume_front("experimental-");
----------------
jrtc27 wrote:
> both to improve the English and to be clear that this is for non-experimental feature strings too
I will fix when I rebase Zbb on top of this


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:19
+
+    class BitMan_GPR_Intrinsics
+        : Intrinsic<[llvm_any_ty],
----------------
jrtc27 wrote:
> This file, like the rest of LLVM, uses a 2-space indent, not 4.
I will fix when I rebase Zbb on top of this. I'll also move it below atomics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99009/new/

https://reviews.llvm.org/D99009