[PATCH] D99045: [x86] Improve selection of the mov instruction in FrameLowering

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 11:01:44 PDT 2021


rnk added a comment.

Seems reasonable



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:253
     if (Reg) {
-      BuildMI(MBB, MBBI, DL, TII.get(MovRIOpc), Reg)
+      BuildMI(MBB, MBBI, DL, TII.get(getMOVriOpcode(Is64Bit, Offset)), Reg)
           .addImm(Offset)
----------------
Offset here is always >2GB, so this is NFC, but still a simplification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99045/new/

https://reviews.llvm.org/D99045



More information about the llvm-commits mailing list