[PATCH] D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 09:45:46 PDT 2021


oontvoo added a comment.

LGTM!



================
Comment at: lld/MachO/Target.h:32
 public:
+  template <class LP> TargetInfo(LP) {
+    // Having these values available in TargetInfo allows us to access them
----------------
I wonder if it's possible to have TargetInfo contains all the stuff the LP* structs below have. That way, we don't have to branch on `target->wordSize` everytime to decide which struct to use .

(doesn't have to be done in this patch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99633/new/

https://reviews.llvm.org/D99633



More information about the llvm-commits mailing list