[PATCH] D99010: [X86][AMX] Hoist ldtilecfg

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:285
+        REPORT_CONFIG_FAIL;
+      std::for_each(MBB->succ_begin(), MBB->succ_end(), [&](auto *Succ) {
+        if (BBVisitedInfo[Succ].NeedTileCfgLiveIn) {
----------------
LuoYuanke wrote:
> If possible, better add a test case for it.
> 
Will do later.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:297
+    if (BBVisitedInfo[MBB].FirstAMX &&
+        BBVisitedInfo[MBB].FirstAMX < BBVisitedInfo[MBB].LastShape)
+      REPORT_CONFIG_FAIL;
----------------
LuoYuanke wrote:
> Is it possible that LastShape is null?
Yes, compare with MIRef() is allowed. The Pos of it is 0. So the condition is false here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99010/new/

https://reviews.llvm.org/D99010