[PATCH] D99284: [RegAllocFast] properly handle STATEPOINT instruction.

Denis Antrushin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 06:35:16 PDT 2021


dantrushin added a comment.

In D99284#2665877 <https://reviews.llvm.org/D99284#2665877>, @skatkov wrote:

> BTW, it seems that previous code was non-optimal or it supports that there are may be ore than one machine operand containing the reg mask.
> If the second is true, you should support this in your patch. Can you check that?

I've never seen instructions with multiple RegMasks and I do not see a reason for multiple RegMasks. This is bitfield big enough to hold all target's physical registers.
After grepping LLVM sources I have no definitive answer either. One can't tell code handling multiple masks from code handling just one, but iterating over all operands just because there is no other way to find regmask (it has no fixed position in MI).

@arsenm : what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99284/new/

https://reviews.llvm.org/D99284



More information about the llvm-commits mailing list