[PATCH] D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:124
+  bool isImm() const override { return Kind == Immediate; }
+  bool isMem() const override { return false; }
+
----------------
MaskRay wrote:
> Is `isMem` unimplemented? If yes, deferring to a subsequent patch is better.
It's implement of pure virtual function, I am afraid it can not ignore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93798/new/

https://reviews.llvm.org/D93798