[lld] d441dee - [lld][MachO] Fix -Wsign-compare warning (NFC)

Yang Fan via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 20:34:17 PDT 2021


Author: Yang Fan
Date: 2021-04-02T11:33:56+08:00
New Revision: d441dee5c266ca0777d06846971e1b436361f361

URL: https://github.com/llvm/llvm-project/commit/d441dee5c266ca0777d06846971e1b436361f361
DIFF: https://github.com/llvm/llvm-project/commit/d441dee5c266ca0777d06846971e1b436361f361.diff

LOG: [lld][MachO] Fix -Wsign-compare warning (NFC)

GCC warning:
```
/llvm-project/lld/MachO/InputFiles.cpp:484:24: warning: comparison of integer expressions of different signedness: ‘int64_t’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
484 |           return value < subsectionEntry.offset;
    |                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
```

Added: 
    

Modified: 
    lld/MachO/InputFiles.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/InputFiles.cpp b/lld/MachO/InputFiles.cpp
index e31c506461f3..c4db50f9e305 100644
--- a/lld/MachO/InputFiles.cpp
+++ b/lld/MachO/InputFiles.cpp
@@ -480,7 +480,7 @@ void ObjFile::parseSymbols(ArrayRef<structs::nlist_64> nList,
     uint64_t offset = sym.n_value - sec.addr;
 
     auto it = llvm::upper_bound(
-        subsecMap, offset, [](int64_t value, SubsectionEntry subsectionEntry) {
+        subsecMap, offset, [](uint64_t value, SubsectionEntry subsectionEntry) {
           return value < subsectionEntry.offset;
         });
     uint32_t size = it != subsecMap.end()


        


More information about the llvm-commits mailing list