[PATCH] D93838: [LLVM] [SCCP] : Add Function Specialization pass

Thu Apr 1 19:13:56 PDT 2021

ChuanqiXu added a comment.

In D93838#2624107 <https://reviews.llvm.org/D93838#2624107>, @mivnay wrote:

> I have updated the full patch along with the cost model. I have also shared the perf numbers for SPEC CPU 2017 benchmarks in Graviton2 with various modes of optimization enabled : F15848356: function_specialize_spec_2017_graviton2.png <https://reviews.llvm.org/F15848356>
>
> This version of the patch contains the FunctionSpecializer implementation inside SCCP.cpp. It is not dependent on the D93762 <https://reviews.llvm.org/D93762> refactoring of `SCCPSolver` just for review purpose.

Hi, may I ask about the optimizations the baseline turned on? Since the Function Specialization pass looks only work under LTO. Does the baseline version run under LTO?
I applied this patch offline to test it. And my baseline was O3 <https://reviews.llvm.org/owners/package/3/> without LTO. So I tried to add this pass to ModulePassPipeline to test it. Then I find the most significant improvements is less than 1%.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838