[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:22
+TARGET_BUILTIN(__builtin_riscv_clmul, "LiLiLi", "nc", "experimental-zbc")
+TARGET_BUILTIN(__builtin_riscv_clmul_h, "LiLiLi", "nc", "experimental-zbc")
+TARGET_BUILTIN(__builtin_riscv_clmul_r, "LiLiLi", "nc", "experimental-zbc")
----------------
I think we should drop the underscore in clmul_h and clmul_r. The mnemonic doesn't have a period between them. So that's different than orc.b and crc32.w.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:82
+    def int_riscv_clmul : BitMan_GPRGPR_Intrinsics;
+    def int_riscv_clmul_h : BitMan_GPRGPR_Intrinsics;
+    def int_riscv_clmul_r : BitMan_GPRGPR_Intrinsics;
----------------
clmul_h -> clmulh
clmul_r -> clmulr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99711/new/

https://reviews.llvm.org/D99711