[llvm] 5379f1c - [MIPS, test] Fix use of undef FileCheck var

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 16:59:49 PDT 2021


Author: Thomas Preud'homme
Date: 2021-04-02T00:59:49+01:00
New Revision: 5379f1c95ca22e81697324908101fc74b7f283ea

URL: https://github.com/llvm/llvm-project/commit/5379f1c95ca22e81697324908101fc74b7f283ea
DIFF: https://github.com/llvm/llvm-project/commit/5379f1c95ca22e81697324908101fc74b7f283ea.diff

LOG: [MIPS, test] Fix use of undef FileCheck var

LLVM test CodeGen/Mips/sr1.ll tries to check for the absence of a
sequence of instructions with several CHECK-NOT with one of those
directives using a variable defined in another. However CHECK-NOT are
checked independently so that is using a variable defined in a pattern
that should not occur in the input.

This commit removes the definition and uses of variable to check each
line independently, making the check stronger than the current one.

Reviewed By: dsanders

Differential Revision: https://reviews.llvm.org/D99776

Added: 
    

Modified: 
    llvm/test/CodeGen/Mips/sr1.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/Mips/sr1.ll b/llvm/test/CodeGen/Mips/sr1.ll
index 25055283534c..77a042167e13 100644
--- a/llvm/test/CodeGen/Mips/sr1.ll
+++ b/llvm/test/CodeGen/Mips/sr1.ll
@@ -47,8 +47,8 @@ entry:
 ; CHECK: 	restore	$16, $17, $ra, $18, [[FS]]
 ; CHECK: 	.end	foo3
 ; NEG: 	.ent	foo3
-; NEG-NOT: 	save	$16, $17, $ra, $18, [[FS:[0-9]+]] # 16 bit inst
-; NEG-NOT: 	restore	$16, $17, $ra, $18, [[FS]] # 16 bit inst
+; NEG-NOT: 	save	$16, $17, $ra, $18, {{[0-9]+}} # 16 bit inst
+; NEG-NOT: 	restore	$16, $17, $ra, $18, {{[0-9]+}} # 16 bit inst
 ; NEG: 	.end	foo3
 }
 


        


More information about the llvm-commits mailing list