[PATCH] D99776: [MIPS, test] Fix use of undef FileCheck var

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 16:44:48 PDT 2021


thopre created this revision.
thopre added reviewers: rkotler, dsanders.
Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis.
thopre requested review of this revision.
Herald added a project: LLVM.

LLVM test CodeGen/Mips/sr1.ll tries to check for the absence of a
sequence of instructions with several CHECK-NOT with one of those
directives using a variable defined in another. However CHECK-NOT are
checked independently so that is using a variable defined in a pattern
that should not occur in the input.

This commit removes the definition and uses of variable to check each
line independently, making the check stronger than the current one.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99776

Files:
  llvm/test/CodeGen/Mips/sr1.ll


Index: llvm/test/CodeGen/Mips/sr1.ll
===================================================================
--- llvm/test/CodeGen/Mips/sr1.ll
+++ llvm/test/CodeGen/Mips/sr1.ll
@@ -47,8 +47,8 @@
 ; CHECK: 	restore	$16, $17, $ra, $18, [[FS]]
 ; CHECK: 	.end	foo3
 ; NEG: 	.ent	foo3
-; NEG-NOT: 	save	$16, $17, $ra, $18, [[FS:[0-9]+]] # 16 bit inst
-; NEG-NOT: 	restore	$16, $17, $ra, $18, [[FS]] # 16 bit inst
+; NEG-NOT: 	save	$16, $17, $ra, $18, {{[0-9]+}} # 16 bit inst
+; NEG-NOT: 	restore	$16, $17, $ra, $18, {{[0-9]+}} # 16 bit inst
 ; NEG: 	.end	foo3
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99776.334854.patch
Type: text/x-patch
Size: 558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210401/23a478a5/attachment.bin>


More information about the llvm-commits mailing list