[PATCH] D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 1 15:54:32 PDT 2021
int3 added a comment.
I do agree that having 32-bit specific code in TargetInfo itself (and its 64-bit child classes) is a bit weird though. So I moved the 32-bit/64-bit property setting code into ILP32 and LP64 respectively, plus made the sole TargetInfo constructor require that one of the two be passed. It's not quite inheritance, and it does require constructing a zero-size struct just for template type inference purposes, but it does the job :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99633/new/
https://reviews.llvm.org/D99633
More information about the llvm-commits
mailing list