[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/Xtensa.def:5
+
+ELF_RELOC (R_XTENSA_NONE, 0)
+ELF_RELOC (R_XTENSA_32, 1)
----------------
MaskRay wrote:
> Don't use a space for macro calls.
Corrected, also aligned right parentheses


================
Comment at: llvm/test/tools/llvm-readobj/ELF/xtensa-header-flags.test:9-12
+# ALL:     Flags [
+# INSN:     EF_XTENSA_XT_INSN (0x100)
+# LIT:      EF_XTENSA_XT_LIT  (0x200)
+# ALL:     ]
----------------
jhenderson wrote:
> No need for the extra indentation.
Corrected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827