[PATCH] D99753: [SLP]Fix a bug in min/max reduction, number of condition uses.

Thu Apr 1 14:00:59 PDT 2021

spatel added a comment.

In D99753#2665134 <https://reviews.llvm.org/D99753#2665134>, @ABataev wrote:

> In D99753#2665081 <https://reviews.llvm.org/D99753#2665081>, @spatel wrote:
>
>> The problem/test looks similar to the one in 0a8e7ca402e <https://reviews.llvm.org/rG0a8e7ca402eb3470eb5faf4982581771cb849130> - can you explain how they differ (what allows these examples to avoid that fix)?
>
> The reduced root is not select instruction anymore, it is an intrinsic call. And we cannot extract the condition

Can we remove the code that was added with D70148 <https://reviews.llvm.org/D70148> then? (assert that the final cmp has only 1 use or 0 remaining uses?)
Hopefully, all of this becomes unnecessary after we switch to the min/max intrinsics.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99753/new/

https://reviews.llvm.org/D99753