[PATCH] D99719: [SLP] Better estimate cost of no-op extracts on target vectors.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3462-3464
+  // Compute the number of number of elements per vector register for
+  // VecTy. If that is not possible, because the number of parts for VecTy
+  // is unknown, the number of elements.
----------------
ABataev wrote:
> fhahn wrote:
> > ABataev wrote:
> > > Is this possible? Or better to make it an assert?
> > Unfortunately that can happen when compiling without a specific target and there's a test that tiggers an assert otherwise.
> Maybe just exit in this case? And rely on the conservative cost model?
yes, I updated it to just return the shuffle cost for the whole `VecTy`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99719/new/

https://reviews.llvm.org/D99719