[PATCH] D99743: [AMDGPU] Use enum for flat variants. NFC

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 10:22:18 PDT 2021


foad added a comment.

Is there some overlap with SIInstrFlags::FLAT, SIInstrFlags::IsFlatScratch, SIInstrFlags::IsFlatGlobal? It seems like your enum is encoding the same thing in a slightly different way. See also the is*FLAT* helper methods in SIInstrInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99743/new/

https://reviews.llvm.org/D99743



More information about the llvm-commits mailing list