[PATCH] D99739: [GlobalISel] Use i32 values for lsb and width with G_SBFX and G_UBFX

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 09:11:09 PDT 2021


arsenm added a comment.

Description is misleading. This should be allow a different type for the offset/width operands, which do not necessarily need to be constant



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:718
 
-  getActionDefinitionsBuilder({G_SBFX, G_UBFX}).customFor({s32, s64});
+  getActionDefinitionsBuilder({G_SBFX, G_UBFX}).customFor({{s32, s32}, {s64, s32}});
 
----------------
Maybe this should keep using i64 for the amounts? It probably doesn't really matter since it only handles constant cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99739/new/

https://reviews.llvm.org/D99739



More information about the llvm-commits mailing list