[PATCH] D98477: [ADT] Add IntrusiveVariant

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 08:06:33 PDT 2021


scott.linder added a comment.

In D98477#2660486 <https://reviews.llvm.org/D98477#2660486>, @dblaikie wrote:

> Perhaps PointerUnion could be implemented as a derivation from this intrusive variant in a follow-up change, subsuming D99561 <https://reviews.llvm.org/D99561>

I'm not as familiar with the implementation of `PointerUnion`, I just noted when I did a pass over the LLVM container types that it wouldn't be sufficient for the specific thing I was working on, so I started writing my own compact variant-like type. At the very least I think we should have a common `llvm::visit` with specializations for both `llvm::PointerUnion` and `llvm::IntrusiveVariant`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98477/new/

https://reviews.llvm.org/D98477



More information about the llvm-commits mailing list