[PATCH] D99479: [RISCV] Add custom type legalization to form MULHSU when possible.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 1 08:02:42 PDT 2021
craig.topper added a comment.
In D99479#2663549 <https://reviews.llvm.org/D99479#2663549>, @asb wrote:
> LGTM.
>
> I think it's OK to land without this, but: Running this patch quickly across the GCC torture suite, the only codegen changes are to 20120817-1.c and pr51581-{1,2}.c on RV32 where a mulhsu is now selected rather than a solitary mulh. I believe this is still correct, but it made me wonder if we are missing some test coverage and should have a codegen test that would demonstrate that change.
I didn't intend that to happen. I was hoping to only affect cases that couldn't be handled by MULH and MULHU. I'll see about making my checks stricter.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99479/new/
https://reviews.llvm.org/D99479
More information about the llvm-commits
mailing list