[PATCH] D99087: [RISCV][WIP] Fix stack slot for argument types (Bug 49500)

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 07:10:48 PDT 2021


asb added a comment.

@frasercrmck you mentioned this patch doesn't quite seem right to you - is there a particular part you're concerned about. I've spent some time going over both this and D99068 <https://reviews.llvm.org/D99068>. The logic of this patch makes more intuitive sense to me, but that may be as it's a long time since I have a better memory of the logic it's modifying. Though Luis' approach does indeed seem to reduce stack size in some cases, and of course directly mirrors the matching SystemZ fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99087/new/

https://reviews.llvm.org/D99087



More information about the llvm-commits mailing list