[PATCH] D99677: [SLP]Improve and fix getVectorElementSize.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a few minor comment updates



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5655
     // We should only be looking at scalar instructions here. If the current
     // instruction has a vector type, give up.
     auto *Ty = I->getType();
----------------
update comment - we don't "give up" anymore


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5668
     // handle the interesting cases from buildTree here. If an operand is an
     // instruction we haven't yet visited, we add it to the worklist.
     else if (isa<PHINode>(I) || isa<CastInst>(I) || isa<GetElementPtrInst>(I) ||
----------------
Update the comment now that we're more selective.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99677/new/

https://reviews.llvm.org/D99677