[PATCH] D99699: [AArch64][SVE] Lowering sve.dot to DOT node

[JunMa via Phabricator via llvm-commits]

junparser added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13342
             Dot.getOpcode() == AArch64ISD::SDOT) &&
-           ISD::isBuildVectorAllZeros(Dot.getOperand(0).getNode());
+           (isDupZero(Dot.getOperand(0)) ||
+            ISD::isBuildVectorAllZeros(Dot.getOperand(0).getNode()));
----------------
dmgreen wrote:
> Can we add a isZerosVector function that encapsulates isBuildVectorAllZeros and the splats/dups logic? It sounds generally useful to have a function that checks for the various ways a vector can be all zeros.
> 
> isConstantSplatVectorAllZeros may also be better, as it may already handle the ISD::SPLAT_VECTOR part.
sound good to me, I'll update this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99699/new/

https://reviews.llvm.org/D99699