[PATCH] D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1235
+      // We need to handle f128 SELECT_CC with integer result type.
+      setOperationAction(ISD::SELECT_CC, MVT::i32, Custom);
+      setOperationAction(ISD::SELECT_CC, MVT::i64, Custom);
----------------
steven.zhang wrote:
> Please confirm if there is any problem with the pattern like: select_cc f128, f128, v2f64, v2f64. Technical speaking, we need to custom all the legalized type.
We don't need to mark vector types for select_cc here. Instead, `select_cc f128, f128, v4i32, v4i32` would crash because of `br_cc` not expanded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92083/new/

https://reviews.llvm.org/D92083