[PATCH] D99710: [AArch64] Use 64-bit movi for zeroing halfs/floats

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 02:54:49 PDT 2021


david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:1115
     }
-    MCInst MOVI;
-    MOVI.setOpcode(AArch64::MOVIv2d_ns);
-    MOVI.addOperand(MCOperand::createReg(DestReg));
     MOVI.addOperand(MCOperand::createImm(0));
     EmitToStreamer(*OutStreamer, MOVI);
----------------
Should this be moved to the `else` case? It looks like we're adding the same immediate twice for the H and S cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99710/new/

https://reviews.llvm.org/D99710



More information about the llvm-commits mailing list