[PATCH] D99693: Update the linkage name of coro-split functions where applicable

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 17:19:24 PDT 2021


aprantl added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:866
+    // linkage name and asserts that they are identical.
+    if (!SP->getDeclaration())
+      SP->replaceLinkageName(MDString::get(Context, NewF->getName()));
----------------
kastiglione wrote:
> Is `!SP->getDeclaration()` the implicit check for swift but not C++?
Yes. If you have a top-level C++ coroutine — and I have no idea if that's a thing, you would get the "real" linkage name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99693/new/

https://reviews.llvm.org/D99693



More information about the llvm-commits mailing list