[PATCH] D98859: [lit] Handle plain negations directly in the internal shell

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 334531.
mstorsjo added a comment.

Improved the testcases for '!'.

Adding a fake external for the 'not' executable is a bit tricky though... With the code as is, for a sequence of 'not not --crash <cmd>', it deduces that there's a '--crash' option in there, and chooses not to switch to the internal not for the outer invocation either.

To fix that case, I'd have to change the code to peel off as many 'not' invocations from the top until the first one with a '--crash' option. Not sure if that's worth the extra complexity for the implementation - what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98859/new/

https://reviews.llvm.org/D98859

Files:
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/tests/Inputs/shtest-not/exclamation-args-nested-none.txt
  llvm/utils/lit/tests/Inputs/shtest-not/exclamation-args-none.txt
  llvm/utils/lit/tests/Inputs/shtest-not/exclamation-calls-external.txt
  llvm/utils/lit/tests/shtest-not.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98859.334531.patch
Type: text/x-patch
Size: 4632 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210331/7d00b1dd/attachment.bin>